Python リファクタリングテクニック：コード品質向上のための包括的なガイド

            
def print_invoice(customer, details):
    print("***********************")
    print(f"Customer: {customer}")
    print("***********************")

    total_amount = 0
    for order in details["orders"]:
        total_amount += order["amount"]

    print(f"Amount is : {total_amount}")

    if total_amount > 1000:
        print("You earned a discount!")

            

              
                Copy
              
            
          

            
def print_header(customer):
    print("***********************")
    print(f"Customer: {customer}")
    print("***********************")

def calculate_total(details):
    total_amount = 0
    for order in details["orders"]:
        total_amount += order["amount"]
    return total_amount

def print_invoice(customer, details):
    print_header(customer)
    total_amount = calculate_total(details)
    print(f"Amount is : {total_amount}")

    if total_amount > 1000:
        print("You earned a discount!")

            

              
                Copy
              
            
          

            
class Person:
    def __init__(self, name, phone_number, office_area_code, office_number):
        self.name = name
        self.phone_number = phone_number
        self.office_area_code = office_area_code
        self.office_number = office_number

    def get_name(self):
        return self.name

    def get_phone_number(self):
        return f"({self.office_area_code}) {self.office_number}"

            

              
                Copy
              
            
          

            
class PhoneNumber:
    def __init__(self, area_code, number):
        self.area_code = area_code
        self.number = number

    def get_phone_number(self):
        return f"({self.area_code}) {self.number}"


class Person:
    def __init__(self, name, phone_number):
        self.name = name
        self.phone_number = phone_number

    def get_name(self):
        return self.name

            

              
                Copy
              
            
          

            
def get_rating(driver):
    return more_than_five_late_deliveries(driver) ? 2 : 1

def more_than_five_late_deliveries(driver):
    return driver.number_of_late_deliveries > 5

            

              
                Copy
              
            
          

            
def get_rating(driver):
    return driver.number_of_late_deliveries > 5 ? 2 : 1

            

              
                Copy
              
            
          

            
def get_price(order):
    base_price = order.quantity * order.item_price
    discount_factor = 0.98 if base_price > 1000 else 0.95
    return base_price * discount_factor

            

              
                Copy
              
            
          

            
def get_price(order):
    return base_price(order) * discount_factor(order)

def base_price(order):
    return order.quantity * order.item_price

def discount_factor(order):
    return 0.98 if base_price(order) > 1000 else 0.95

            

              
                Copy
              
            
          

            
def calculate_total(width, height, depth, weight, shipping_method):
    # Calculation logic
    pass

            

              
                Copy
              
            
          

            
class ShippingDetails:
    def __init__(self, width, height, depth, weight, shipping_method):
        self.width = width
        self.height = height
        self.depth = depth
        self.weight = weight
        self.shipping_method = shipping_method

def calculate_total(shipping_details):
    # Calculation logic using shipping_details attributes
    pass

            

              
                Copy
              
            
          

            
def calculate_bonus(employee):
    if employee.employee_type == "SALES":
        return employee.sales * 0.1
    elif employee.employee_type == "ENGINEER":
        return employee.projects_completed * 100
    elif employee.employee_type == "MANAGER":
        return 1000
    else:
        return 0

            

              
                Copy
              
            
          

            
class Employee:
    def calculate_bonus(self):
        return 0


class SalesEmployee(Employee):
    def __init__(self, sales):
        self.sales = sales

    def calculate_bonus(self):
        return self.sales * 0.1


class EngineerEmployee(Employee):
    def __init__(self, projects_completed):
        self.projects_completed = projects_completed

    def calculate_bonus(self):
        return self.projects_completed * 100


class ManagerEmployee(Employee):
    def calculate_bonus(self):
        return 1000

            

              
                Copy
              
            
          

            
if (platform.upper().index("MAC") > -1) and (browser.upper().index("IE") > -1) and was_initialized() and resize > MAX_RESIZE:
    # Do something
    pass

            

              
                Copy
              
            
          

            
def is_mac_os():
    return platform.upper().index("MAC") > -1

def is_ie_browser():
    return browser.upper().index("IE") > -1


if is_mac_os() and is_ie_browser() and was_initialized() and resize > MAX_RESIZE:
    # Do something
    pass

            

              
                Copy
              
            
          

            
def calculate_area(radius):
    return 3.14159 * radius * radius

            

              
                Copy
              
            
          

            
PI = 3.14159

def calculate_area(radius):
    return PI * radius * radius

            

              
                Copy
              
            
          

            
class Person:
    def __init__(self, department):
        self.department = department

    def get_manager(self):
        return self.department.get_manager()


class Department:
    def __init__(self, manager):
        self.manager = manager

    def get_manager(self):
        return self.manager

            

              
                Copy
              
            
          

            
class Person:
    def __init__(self, manager):
        self.manager = manager

    def get_manager(self):
        return self.manager

            

              
                Copy
              
            
          

            
def calculate_discount(price, discount_percentage):
    if discount_percentage < 0 or discount_percentage > 100:
        raise ValueError("Discount percentage must be between 0 and 100")
    return price * (1 - discount_percentage / 100)

            

              
                Copy
              
            
          

            
def calculate_discount(price, discount_percentage):
    assert 0 <= discount_percentage <= 100, "Discount percentage must be between 0 and 100"
    return price * (1 - discount_percentage / 100)

            

              
                Copy
              
            
          

            
import datetime

def format_date(date):
    return date.strftime("%m/%d/%Y")  # US date format

            

              
                Copy
              
            
          

            
import datetime
import locale

def format_date(date, locale_code):
    locale.setlocale(locale.LC_TIME, locale_code)
    return date.strftime("%x")  # Locale-specific date format

# Example usage:
# format_date(datetime.date(2024, 1, 1), 'en_US.UTF-8') # Output: '01/01/2024'
# format_date(datetime.date(2024, 1, 1), 'de_DE.UTF-8') # Output: '01.01.2024'

            

              
                Copy